fix: Failing regression test #2918
Conversation
DafyddLlyr
force-pushed
the
dp/fix-regression-test-itp-bops
branch
from
2683aa9 to
284a032
Compare
|
Removed vultr server and associated DNS entries |
| @@ -10,6 +10,7 @@ export function createTeam( | |||
| slug: "E2E", | |||
| submissionEmail: TEST_EMAIL, | |||
| homepage: "planx.uk", | |||
| referenceCode: "ABCD", | |||
There was a problem hiding this comment.
This is a mandatory field to generate a valid payload.
planx-core now makes this required with this change - theopensystemslab/planx-core#337
There was a problem hiding this comment.
I copy/pasted the most recent version of the flow here to resolve schema issues.
I needed to manually update the Pay component with the govPayMetadata field - I'll open a PR shortly to either properly handle defaults or to make a data migration.
There was a problem hiding this comment.
I'm a little confused by this - is it actually an issue of outdated flow mocks or the mock session data referenced by the graphql query mocks (or both)? Eg I'm surprised to not see these updates repeated here https://github.com/theopensystemslab/planx-new/pull/2872/files
There was a problem hiding this comment.
The only errors were coming from outdated flow mocks, which is what I've updated here. I was also surprised by this, but I guess the variables in question are optional?
This field is actually required in order to generate a valid DigitalPlanning payload. Please see theopensystemslab/planx-new#2918 for context.
|
🤖 Hasura Change Summary compared a subset of table metadata including permissions: Updated Tables (1)
|
DafyddLlyr
force-pushed
the
dp/fix-regression-test-itp-bops
branch
from
48a2646 to
cc84887
Compare
Regression tests passing locally ✅
Running against this branch in CI here - https://github.com/theopensystemslab/planx-new/actions/runs/8419529120 ✅
Problem
The regression test for "send to BOPS" was failing for a number of reasons - please see comments and changes on PR.
The main / original issue was that the mock flow was outdated - meaning that payload generation was failing.
Solution
planx-core(and a script to pull latest version?). We could then expose these via imports intoplanx-newand just need to update a single flow once as opposed to keeping multiple copies. Something to discuss next dev call!